Add default Anthropic autocomplete model (#4803)

Fixes the default model value for the Anthropic autocomplete provider.
sourcegraph · Jul 17, 2024 · 57a0f8f · 57a0f8f
1 parent 5e37b75
commit 57a0f8f
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/vscode/CHANGELOG.md b/vscode/CHANGELOG.md
@@ -54,6 +54,7 @@ This is a log of all notable changes to Cody for VS Code. [Unreleased] changes a
 
 - Edit: Fixed an issue where, when unable to detect the indentation of a file, Cody would remove all indentation from a response. [pull/4704](https://github.com/sourcegraph/cody/pull/4704)
 - Edit: Fixed an issue where Cody would sometimes remove unintended parts of the code when an edit was accepted on save. [pull/4720](https://github.com/sourcegraph/cody/pull/4720)
+- Autocomplete: Fixes the default model value for the Anthropic autocomplete provider. [pull/4803](https://github.com/sourcegraph/cody/pull/4803)
 - Chat: The loading dots in the loading page are now centered correctly. [pull/4808](https://github.com/sourcegraph/cody/pull/4808)
 
 ### Changed

diff --git a/vscode/src/completions/get-inline-completions-tests/analytics.test.ts b/vscode/src/completions/get-inline-completions-tests/analytics.test.ts
@@ -136,7 +136,7 @@ describe('[getInlineCompletions] completion event', () => {
                   "multiline": true,
                   "multilineMode": "block",
                   "providerIdentifier": "anthropic",
-                  "providerModel": "claude-instant-1.2",
+                  "providerModel": "anthropic/claude-instant-1.2",
                   "resolvedModel": "sourcegraph/gateway-model",
                   "responseHeaders": {
                     "fireworks-speculation-matched-tokens": "100",
@@ -205,7 +205,7 @@ describe('[getInlineCompletions] completion event', () => {
                   "multiline": false,
                   "multilineMode": null,
                   "providerIdentifier": "anthropic",
-                  "providerModel": "claude-instant-1.2",
+                  "providerModel": "anthropic/claude-instant-1.2",
                   "resolvedModel": "sourcegraph/gateway-model",
                   "responseHeaders": {
                     "fireworks-speculation-matched-tokens": "100",

diff --git a/vscode/src/completions/providers/anthropic.ts b/vscode/src/completions/providers/anthropic.ts
@@ -288,6 +288,7 @@ export function createProviderConfig({
     providerOptions,
     ...otherOptions
 }: AnthropicOptions & { providerOptions?: Partial<ProviderOptions> }): ProviderConfig {
+    const defaultClientModel = model ?? 'anthropic/claude-instant-1.2'
     return {
         create(options: ProviderOptions) {
             return new AnthropicProvider(
@@ -296,12 +297,12 @@ export function createProviderConfig({
                     ...providerOptions,
                     id: PROVIDER_IDENTIFIER,
                 },
-                { maxContextTokens, model, ...otherOptions }
+                { maxContextTokens, model: model ?? defaultClientModel, ...otherOptions }
             )
         },
         contextSizeHints: standardContextSizeHints(maxContextTokens),
         identifier: PROVIDER_IDENTIFIER,
-        model: model ?? 'claude-instant-1.2',
+        model: model ?? defaultClientModel,
     }
 }
 

diff --git a/vscode/src/completions/providers/create-provider.test.ts b/vscode/src/completions/providers/create-provider.test.ts
@@ -62,7 +62,7 @@ describe('createProviderConfig', () => {
                 dummyAuthStatus
             )
             expect(provider?.identifier).toBe('anthropic')
-            expect(provider?.model).toBe('claude-instant-1.2')
+            expect(provider?.model).toBe('anthropic/claude-instant-1.2')
         })
 
         it('returns "fireworks" provider config and corresponding model if specified', async () => {
@@ -137,7 +137,7 @@ describe('createProviderConfig', () => {
                 dummyAuthStatus
             )
             expect(provider?.identifier).toBe('anthropic')
-            expect(provider?.model).toBe('claude-instant-1.2')
+            expect(provider?.model).toBe('anthropic/claude-instant-1.2')
         })
 
         it('provider specified in VSCode settings takes precedence over the one defined in the site config', async () => {
@@ -200,7 +200,7 @@ describe('createProviderConfig', () => {
                         provider: 'aws-bedrock',
                         completionModel: 'anthropic.claude-instant-1.2',
                     },
-                    expected: { provider: 'anthropic', model: 'claude-instant-1.2' },
+                    expected: { provider: 'anthropic', model: 'anthropic/claude-instant-1.2' },
                 },
                 {
                     codyLLMConfig: { provider: 'aws-bedrock', completionModel: 'anthropic.' },
@@ -256,7 +256,7 @@ describe('createProviderConfig', () => {
                 // provider not defined (backward compat)
                 {
                     codyLLMConfig: { provider: undefined, completionModel: 'superdupercoder-7b' },
-                    expected: { provider: 'anthropic', model: 'claude-instant-1.2' },
+                    expected: { provider: 'anthropic', model: 'anthropic/claude-instant-1.2' },
                 },
             ]
 
@@ -287,6 +287,6 @@ describe('createProviderConfig', () => {
             dummyAuthStatus
         )
         expect(provider?.identifier).toBe('anthropic')
-        expect(provider?.model).toBe('claude-instant-1.2')
+        expect(provider?.model).toBe('anthropic/claude-instant-1.2')
     })
 })