Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document sync & completions fix #192

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

tomaszgolebiowski
Copy link
Collaborator

Test plan

  • Create a new solution
  • Start adding code
  • Check if 'grey code' with suggestions appears
  • Accept the suggestions by pressing Tab
  • Reject the suggestion by pressing Esc

Copy link

github-actions bot commented Jan 6, 2025

Test Results

24 tests  +7   24 ✅ +7   3m 1s ⏱️ - 11m 58s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit ec587a8. ± Comparison against base commit bbe2c1a.

@@ -93,12 +90,6 @@ private void OnSuggestionAccepted(object sender, SuggestionAcceptedEventArgs e)

public async override Task<ProposalSourceBase> GetProposalSourceAsync(ITextView view, CancellationToken cancel)
{
//var list = Input.ToArray();
Copy link
Collaborator

@PiotrKarczmarz PiotrKarczmarz Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is not used for debugging //[ImportMany] public IEnumerable<ProposalSourceProviderBase> Input { get; set; }?

I would say it could stay then, as useful debugging help.

namespace Cody.Core.Tests
{
[TestFixture]
public class StringExtensionsTests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tomaszgolebiowski tomaszgolebiowski merged commit 8c4074e into main Jan 6, 2025
6 checks passed
@tomaszgolebiowski tomaszgolebiowski deleted the tg/ui-thread-in-sync branch January 6, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants