Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E Test: Sign in page check update #140

Merged
merged 3 commits into from
Nov 6, 2024
Merged

E2E Test: Sign in page check update #140

merged 3 commits into from
Nov 6, 2024

Conversation

PiotrKarczmarz
Copy link
Collaborator

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Test Results

15 tests  +5   15 ✅ +5   28m 2s ⏱️ + 6m 58s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit bf58a5a. ± Comparison against base commit 61f6ca7.

This pull request removes 1 and adds 6 tests. Note that renamed tests count towards both. 
Cody.VisualStudio.Tests.ChatNotLoggedStateTests ‑ Loads_Properly_InNotLoggedState - 2022 Exp

Cody.Core.Tests.CustomConfigurationTests ‑ Complex_JSON_Data_Should_Be_Serializable
Cody.Core.Tests.CustomConfigurationTests ‑ CustomConfiguration_Malformed_JSON_Should_Return_Null
Cody.Core.Tests.CustomConfigurationTests ‑ Simple_JSON_Data_Should_Be_Serializable
Cody.VisualStudio.Tests.ChatNotLoggedStateTests ‑ Cody_Enterprise_Section_Is_Present - 2022 Exp
Cody.VisualStudio.Tests.ChatNotLoggedStateTests ‑ Cody_Free_Cody_Pro_Section_Is_Present - 2022 Exp
Cody.VisualStudio.Tests.ChatNotLoggedStateTests ‑ Logins_With_GitLab_Google_Are_Present - 2022 Exp

abeatrix
abeatrix approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@abeatrix abeatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@PiotrKarczmarz PiotrKarczmarz merged commit 0f62067 into main Nov 6, 2024
3 checks passed
@PiotrKarczmarz PiotrKarczmarz deleted the piotr/e2e-login-page branch November 6, 2024 11:57
tomaszgolebiowski pushed a commit that referenced this pull request Dec 11, 2024
@PiotrKarczmarz
E2E Test: Sign in page check update (#140)
e4c0946 
- Added test for Cody Free/Cody Enterprise sections
- Introduced ThreadHelper.JoinableTaskContext to use single setup step for every test in the constructor

CLOSE https://linear.app/sourcegraph/issue/CODY-4234/e2e-test-sign-in-page-check-update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeatrix abeatrix abeatrix approved these changes

@tomaszgolebiowski tomaszgolebiowski tomaszgolebiowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PiotrKarczmarz @tomaszgolebiowski @abeatrix