swss: Align STP structures and remove GCC diagnostic pragmas #3440
+175
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What I did: - Updated stpmgr.h to replace packed structs with aligned structs - Replaced the old processStpPortAttr in stpmgr.cpp with a version that uses properly aligned STP_PORT_CONFIG_MSG allocations How I did it: - Applied the same alignment fixes from 202211 branch to master - Removed #pragma GCC diagnostic usage and introduced ALIGNED(4) as well as padding fields in the relevant STP_* structures Why I did it: - To resolve address-of-packed-member warnings that break builds with certain compiler/platform configurations (e.g., Broadcom) - Aligning data structures properly avoids potential misalignment errors Signed-off-by: Omar Tamer <[email protected]> Signed-off-by: omaaartamer <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@divyachandralekha , please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[swss]: Align STP Structures for bullseye/Broadcom & Remove GCC Diagnostic Pragmas
What I did
stpmgr.hto replace packed structs with aligned structsprocessStpPortAttrinstpmgr.cppwith a version that uses properly alignedSTP_PORT_CONFIG_MSGallocationsHow I did it
master#pragma GCC diagnosticusageALIGNED(4)macros and added padding for the relevantSTP_*structuresWhy I did it
Target Platform/OS
Test
Signed-off-by: Omar Tamer <[email protected]>
What I did
stpmgr.hto use aligned structsprocessStpPortAttrinstpmgr.cppWhy I did it
How I verified it
Details if related