Remove update of mgmt oper status in swss #3439
Open
+3
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suvarna Meenakshi <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@SuvarnaMeenakshi , could you link the original PR that added this feature? Is there any other dependency that we've to address? |
|
prsunny
reviewed
Jan 6, 2025
| @@ -50,43 +49,6 @@ LinkSync::LinkSync(DBConnector *appl_db, DBConnector *state_db) : | |||
| { | |||
| string key = idx_p->if_name; | |||
|
|
|||
| /* Explicitly store management ports oper status into the state database. | |||
There was a problem hiding this comment.
Why do we need to keep the for loop as this was also added as part of #630
There was a problem hiding this comment.
Yes, we don't need this, removed to match initial PR changes
prsunny
reviewed
Jan 6, 2025
| @@ -197,17 +159,6 @@ void LinkSync::onMsg(int nlmsg_type, struct nl_object *obj) | |||
| nlmsg_type, key.c_str(), admin, oper, addrStr, ifindex, master); | |||
| } | |||
|
|
|||
| if (!key.compare(0, MGMT_PREFIX.length(), MGMT_PREFIX)) | |||
There was a problem hiding this comment.
I think we should remove the check at line 134 as well
There was a problem hiding this comment.
Removed this : key.compare(0, MGMT_PREFIX.length(), MGMT_PREFIX)
|
@SuvarnaMeenakshi, can you please address the comments? |
in PR sonic-net#630 Signed-off-by: Suvarna Meenakshi <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Issue to be fix: Currently operational status of mgmt interface is not present or correct for multi-asic devices.
Why I did it
Initial PR that added mgmt oper status feature in swss: #630
sonic-net/sonic-buildimage#21245 adds a script to update oper status of management interface periodically. In doing so, we no longer need to update oper status of mgmt interface in swss.
How I verified it
Verified on single-asic platform
Details if related