[orchagent] implement ring buffer feature with a flag #3242
+408
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a114j0y
force-pushed
the
master
branch
2 times, most recently
from
7f23081 to
8062ead
Compare
a114j0y
force-pushed
the
master
branch
9 times, most recently
from
3d3cde6 to
ba7f1a0
Compare
|
can you please add sone swss tests for this functionality. There are no tests mentioned in the PR. if you have created a separate PR , Please link it here. |
siqbal1986
reviewed
Sep 11, 2024
a114j0y
force-pushed
the
master
branch
2 times, most recently
from
80e7a90 to
a6b3b0c
Compare
a114j0y
force-pushed
the
master
branch
6 times, most recently
from
2ccb3dc to
12b402a
Compare
siqbal1986
approved these changes
Oct 30, 2024
|
rebased and conflict resolved @siqbal1986 could you help re-approve it? : ) |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
swss::TableBase* Consumer::getConsumerTable() const overrideswss::ConsumerTableBase *Why I did it
APP_ROUTE_TABLEconsumers doing tasksHow I verified it
measure the performance with PerformanceTimer