Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_dhcp_relay_stress Testcase: Remove XFail Conditions for dualtor #16374

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

yyynini
Copy link
Contributor

@yyynini yyynini commented Jan 7, 2025

Description of PR

Summary:
Fixes # (issue)
https://msazure.visualstudio.com/One/_workitems/edit/30281490/?view=edit

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Testcase fails under certain conditions in dualtor.
The XFail Conditions PR: #15811

How did you do it?

code: [ptf] Consider only expected packets for timeout by vkjammala-arista · Pull Request #21150 · sonic-net/sonic-buildimage
add dualtor fixture for test_dhcp_relay_stress by yyynini · Pull Request #16171 · sonic-net/sonic-mgmt

How did you verify/test it?

Testcase passed in dualtors.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yyynini
Copy link
Contributor Author

yyynini commented Jan 7, 2025

image

passed now:
image
image

Copy link
Contributor

@yaqiangz yaqiangz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 3ea9240 into sonic-net:master Jan 10, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants