Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use readwrite as the default role #16365

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

ganglyu
Copy link
Contributor

@ganglyu ganglyu commented Jan 7, 2025

Description of PR

Summary:
Fixes # (issue)
Microsoft ADO: 30073317

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

GNMI needs to use role to in API operations, for example, read-only user can't call write API.

How did you do it?

Modify current end to end test, default role should be rw.

How did you verify/test it?

Run gnmi end to end test.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ganglyu ganglyu requested a review from liuh-80 January 7, 2025 03:05
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ganglyu ganglyu changed the title Use rw as the default role Use readwrite as the default role Jan 7, 2025
@wangxin wangxin merged commit 5e31523 into sonic-net:master Jan 9, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants