test_config_fec_oper_mode: Set the fec_mode to align with the current configuration of the interface. #16360
+21
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
vvolam
requested review from
Copilot and
dgsudharsan
and removed request for
prgeor
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
tests/platform_tests/test_intf_fec.py:95
- [nitpick] The variable name 'fec_mode' is ambiguous. It should be renamed to 'current_fec_mode' for better clarity.
fec_mode = get_fec_oper_mode(duthost, intf['interface'])
tests/platform_tests/test_intf_fec.py:97
- The error message could be more informative by including more context about the failure.
pytest.fail("FEC status is N/A for interface {}".format(intf['interface']))
|
LGTM for the config check, maybe need to also check if interface is up before the test starts |
bingwang-ms
reviewed
Jan 7, 2025
bingwang-ms
reviewed
Jan 7, 2025
@vdahiya12 Thank you! Yes, this is done at line 63(53 in old) already. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 16360 in repo sonic-net/sonic-mgmt |
bingwang-ms
reviewed
Jan 8, 2025
bingwang-ms
approved these changes
Jan 8, 2025
vdahiya12
approved these changes
Jan 8, 2025
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
As the FEC mode can be set to "none" as well, instead of setting the FEC mode to rs when testing the configuration, set the FEC mode to existing configuration of the interface.
Summary:
Fixes # (issue) #16120
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Verified the fix on lab testbed where the FEC mode is set to "none" and the test case is failing before the fix.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation