Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snappi] Adding Ungraceful Restart script for BGP Outbound cases #16359

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

selldinesh
Copy link
Contributor

Description of PR

Summary:Adding Ungraceful Restart script as part of BGP Outbound cases
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

To add Ungraceful restart case

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -20,8 +21,7 @@
snappi_portchannel_ipv4_list, snappi_portchannel_ipv6_list, AS_PATHS, \
BGP_TYPE, t1_side_interconnected_port, t2_side_interconnected_port, router_ids, \
snappi_community_for_t1, snappi_community_for_t1_drop, snappi_community_for_t2, num_regionalhubs, \
SNAPPI_TRIGGER, DUT_TRIGGER, fanout_presence, t2_uplink_fanout_info # noqa: F401
from tests.common.snappi_tests.variables import v6_prefix_length
SNAPPI_TRIGGER, DUT_TRIGGER, fanout_presence, t2_uplink_fanout_info, v6_prefix_length # noqa: F401
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v6_prefix_length is no longer present in variables.py file.

@deepak-singhal0408 deepak-singhal0408 self-requested a review January 6, 2025 22:39
format(device_hostname, ansible_dut_hostnames))
pytest_assert(False, "Mismatch between the dut hostnames in ansible and in variables.py files")
snappi_extra_params.device_name = t1_t2_device_hostnames[hw_platform][3]
if (len(t1_t2_device_hostnames[hw_platform]) < 3) or (len(duthosts) < 3):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets remove this check for consistency.

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@deepak-singhal0408
Copy link
Contributor

@selldinesh PR checker(Pre_test Validate failing)..

Could you fix the import error..

2025-01-07T00:18:39.3756408Z ==================================== ERRORS ====================================
2025-01-07T00:18:39.3756592Z _ ERROR collecting snappi_tests/multidut/bgp/test_bgp_outbound_ungraceful_restart.py _
2025-01-07T00:18:39.3756889Z ImportError while importing test module '/var/src/sonic-mgmt/tests/snappi_tests/multidut/bgp/test_bgp_outbound_ungraceful_restart.py'.
2025-01-07T00:18:39.3757094Z Hint: make sure your test modules/packages have valid Python names.
2025-01-07T00:18:39.3757225Z Traceback:
2025-01-07T00:18:39.3757365Z /usr/lib/python3.8/importlib/init.py:127: in import_module
2025-01-07T00:18:39.3757528Z return _bootstrap._gcd_import(name[level:], package, level)
2025-01-07T00:18:39.3757695Z snappi_tests/multidut/bgp/test_bgp_outbound_ungraceful_restart.py:9: in
2025-01-07T00:18:39.3757877Z from tests.snappi_tests.multidut.bgp.files.bgp_outbound_helper_pr import (
2025-01-07T00:18:39.3758131Z E ModuleNotFoundError: No module named 'tests.snappi_tests.multidut.bgp.files.bgp_outbound_helper_pr'

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

linux-foundation-easycla bot commented Jan 7, 2025

CLA Missing ID CLA Not Signed

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants