Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add once_map package #1665

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Add once_map package #1665

merged 1 commit into from
Jan 7, 2025

Conversation

maciektr
Copy link
Contributor

@maciektr maciektr commented Oct 22, 2024

commit-id:293590d9


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@maciektr maciektr force-pushed the spr/main/293590d9 branch 2 times, most recently from a4d0ee0 to 3fc352c Compare October 26, 2024 20:38
@maciektr maciektr force-pushed the spr/main/293590d9 branch 4 times, most recently from 31cbe81 to 33a0dad Compare November 4, 2024 22:52
@maciektr maciektr force-pushed the spr/main/293590d9 branch 2 times, most recently from aa612cb to c117830 Compare November 19, 2024 21:01
@maciektr maciektr marked this pull request as ready for review November 25, 2024 14:42
@maciektr maciektr requested a review from a team as a code owner November 25, 2024 14:42
Copy link
Member

@wawel37 wawel37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see OnceMap tests in the original repo, but it seems that some bugs appeared there not that long ago (astral-sh/uv#3987). I am not saying that it's unstable or anything, but i think it would be nice to have some tests for it in the future.

github-merge-queue bot pushed a commit that referenced this pull request Jan 7, 2025
commit-id:3ba8d8f0

---

**Stack**:
- #1453
- #1665
- #1452⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Base automatically changed from spr/main/3ba8d8f0 to main January 7, 2025 15:07
commit-id:293590d9
@maciektr maciektr enabled auto-merge January 7, 2025 22:15
@maciektr maciektr added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit e18c4ef Jan 7, 2025
26 of 37 checks passed
@maciektr maciektr deleted the spr/main/293590d9 branch January 7, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants