forked from tlatorre-uchicago/minard
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement slow control data plotting page #287
Open
lucs100
wants to merge
47
commits into
snoplus:master
Choose a base branch
from
lucs100:slowcontrol-plots
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for multiple lines on one plot
Code reuse between new and append; store timestamps to avoid data mismatch
+ whitespace changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a new page on Minard to plot historical slow controls data.
Features
Code changes
New files
slowcontrol_plots.html
: The slow control plotting web page. Written using the run selection page layout/logic as a starting point.slowcontrol_plots.js
: Extra JS logic for the slow control plotting page (bulkier functions that don't make sense to keep in a<script>
in the HTML).slowcontrol_data.py
: Communicates with the snoplus CouchDB server over HTTP (using grequests to multithread chunks of the request) to request data, then package it to pass back to the webpage. This file holds the bulk of the actual logic and is commented throughout.Changed files
layout.html
: Adds the slowcontrol plot page to the Polling dropdown in the navbar.views.py
: Accepts a request from the webpage and returns data once ready.gitignore.txt
: Adds ignore rules for some scripts on vminard for convenience. Change is not neccesary.requirements.txt
: Addsgrequests==0.7.0
. Library is required for multithreaded HTTP requests to CouchDB.Requirements:
grequests==0.7.0
.Screenshot:
Concerns:
COUCH_USER
andCOUCH_PASS
(specifically on Line 12 ofslowcontrol_data.py
). I'm not sure if the minard configuration has these environment variables set.