ECO-294/Form-errors #172
Merged
ECO-294/Form-errors #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tomasdrga
commented
Jul 25, 2024
tomasdrga
commented
- Problem bol v .js pre autoform, ktory blokoval .js pre ostatne forms, ktore boli za nim.
- Upravil som vsetky formulare aby spravne ukazovali errors a success a aby sa spravne zatvarali (nenechavali error inputy)
|
@tomasdrga mierne som sa stratil, co blokovalo? |
tomasdrga
commented
Jul 25, 2024
| @@ -29,33 +44,19 @@ $(document).ready(function() { | |||
| return true; | |||
| } | |||
| }); | |||
|
|
|||
| var autoformError = $('#autoform-error').get(0); | |||
There was a problem hiding this comment.
@jsuchal konkretne tato cast, ktora hladala na kazdej pagy autoform classy
There was a problem hiding this comment.
Ale ved to by nemalo vadit nie? Nenajde tak nie je problem.
tomasdrga
commented
Aug 2, 2024
| @@ -29,33 +44,19 @@ $(document).ready(function() { | |||
| return true; | |||
| } | |||
| }); | |||
|
|
|||
| var autoformError = $('#autoform-error').get(0); | |||
| addCloseButtonListener(autoformError); | |||
There was a problem hiding this comment.
@jsuchal chcel som označiť tento riadok, keď sa nenájde autoformError z predchádzajúceho riadku nič sa nestane, no keď sa potom posunie do funkcie addCloseButtonListener(autoformError);, tak to zlyhá na var closeButton = node.querySelector('.alert .close'); , preto sa toto teraz udeje iba keď sa nájde autoformError
jsuchal
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.