Fixed first save of settings on install

sjelfull · Apr 4, 2018 · fc5688d · fc5688d
1 parent b16033a
commit fc5688d
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 16 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## Unreleased
+
+### Fixed
+- Fixed first save of settings on install
+
 ## 1.0.0 - 2018-04-04
+
 ### Added
 - Initial release
diff --git a/src/Audit.php b/src/Audit.php
@@ -95,6 +95,22 @@ public function init()
             $this->controllerNamespace = 'superbig\audit\console\controllers';
         }
 
+        Event::on(
+            Plugins::class,
+            Plugins::EVENT_AFTER_INSTALL_PLUGIN,
+            function(PluginEvent $event) {
+                if ($event->plugin === $this) {
+                    $settings = $this->getSettings();
+
+                    if (empty($settings->updateAuthKey)) {
+                        $settings->updateAuthKey = StringHelper::randomString(16);
+
+                        Craft::$app->getPlugins()->savePluginSettings($this, $settings->toArray());
+                    }
+                }
+            }
+        );
+
         /**
          * Install our event listeners. We do it only after we receive the event
          * EVENT_AFTER_LOAD_PLUGINS so that any pending db migrations can be run
@@ -110,22 +126,6 @@ function() {
                         $this->initLogEvents();
                     });
             }
-
-            Event::on(
-                Plugins::class,
-                Plugins::EVENT_AFTER_INSTALL_PLUGIN,
-                function(PluginEvent $event) {
-                    if ($event->plugin === $this) {
-                        $settings = $this->getSettings();
-
-                        if (empty($settings->updateAuthKey)) {
-                            $settings->updateAuthKey = StringHelper::randomString(16);
-
-                            Craft::$app->getPlugins()->savePluginSettings($this, $settings->toArray());
-                        }
-                    }
-                }
-            );
         }
 
         Event::on(