Skip to content

Commit

Permalink
Revert regctl & switch BuildKit off
Browse files Browse the repository at this point in the history
  • Loading branch information
sixeyed committed Jan 7, 2025
1 parent f1874c6 commit a665506
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 15 deletions.
3 changes: 2 additions & 1 deletion .github/actions/build/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,5 @@ runs:
env:
BUILD_IMAGES: ${{ inputs.images }}
BUILD_CHAPTERS: ${{ inputs.chapters }}
FILTER: ${{ inputs.filter }}
FILTER: ${{ inputs.filter }}
DOCKER_BUILDKIT: 0
3 changes: 2 additions & 1 deletion .github/actions/push-manifests/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,5 @@ runs:
env:
BUILD_IMAGES: ${{ inputs.images }}
BUILD_CHAPTERS: ${{ inputs.chapters }}
FILTER: ${{ inputs.filter }}
FILTER: ${{ inputs.filter }}
DOCKER_BUILDKIT: 0
6 changes: 0 additions & 6 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -153,12 +153,6 @@ jobs:
- chapters-windows-ltsc2025
runs-on: ubuntu-latest
steps:
- uses: regclient/actions/regctl-installer@main
- uses: regclient/actions/regctl-login@main
with:
registry: docker.io
username: ${{ secrets.DOCKER_HUB_USERNAME }}
password: ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }}
- uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKER_HUB_USERNAME }}
Expand Down
8 changes: 1 addition & 7 deletions build/push-manifests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ param(
[string]$Filter=$null,
[switch]$Images=$true,
[switch]$Chapters=$false,
[switch]$UseRegctl=$true,
[switch]$Delete=$false,
[switch]$Pull=$false
)
Expand Down Expand Up @@ -51,12 +50,7 @@ try {
$variantList = @()
foreach ($variant in $variants) {
$ref = "$($image)-$variant"
if ($UseRegctl) {
$manifest = regctl manifest get $ref --format raw-body | ConvertFrom-Json
}
else {
$manifest = docker manifest inspect $ref | ConvertFrom-Json
}
$manifest = docker manifest inspect $ref | ConvertFrom-Json
if ($null -ne $manifest -and $manifest.mediaType -eq $manifestMediaType) {
$variantList += $ref
echo "** Image variant found. Will add to manifest list: $ref"
Expand Down

0 comments on commit a665506

Please sign in to comment.