Fix colors #22
Open
Fix colors #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise gives an error on the tty solution inspired by https://stackoverflow.com/a/41978310 which in turn comes from tmux: pr for feature: https://github.com/tmux/tmux/pull/432/files actual code: https://github.com/tmux/tmux/blob/fc204bb5e5e6ef4e48f6d6d2b087d2881ad9cf6e/colour.c#L56
note that the ISC license is gpl compatible, so I can use it in this project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now using this plugin in the tty gives an error on setup because it attempts to set highlight groups with hex values. This borrows a hex color to 256 color translation function from tmux and applies it where appropriate to avoid this error.
Definitely open to easer/better solutions.
I included the required license notice with the borrowed code, which is GPL compatible.