Stage/Working Color highlight in FilePanel #490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I really like your plugin, it's straightforward and exactly what I was looking for my git integration.
I have one minor annoyance : I don't like that "Changes" and "Staged changes" appear with the same highlight. It confused me a few time when one of the two list isn't present, I would find clearer something green-ish for the Staged changes.
I thought I could just come up with a
hi link
of sorts, but since it's the same hl group for both, there is not much I could do without changing the DiffView source.The current Pull Request is just a first step to show what I'm talking about. It would allows for colors scheme implementer (or myself in my config) to tweak the color of each Title afterwards.
My plan was to give a specific name for each Title, and then link all theses to a generic name, so that it doesn't break any existing behavior, or something alike.
However, my understanding of the
hi link
conventions is quite limited, and I couldn't figure how theDiffviewFilePanelTitle
hl group even ends up being red in my config. I tested with a few colorschemes, and the titles would have different colors, without me being able to get how this ends up to be.If somebody would be able to point me in the right direction, I would be very grateful to learn something and elaborate on the PR.
Also, feel free to close this issue if you consider that it's too minor to be worth the effort.
All the best and thanks for the great work