Skip to content

Commit

Permalink
Update pull_request_template.md
Browse files Browse the repository at this point in the history
  • Loading branch information
sindresorhus authored Jan 7, 2025
1 parent 203528d commit e4e6228
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ If you're adding support for a new file type, please follow the below steps:
- Add a fixture file named `fixture.<extension>` to the `fixture` directory.
- Add the file extension to the `extensions` array in `supported.js`.
- Add the file's MIME type to the `types` array in `supported.js`.
- Add the file type detection logic to the `core.js` file
- Add the file type detection logic to the `core.js` file.
- Determine the appropriate detection confidence category:
- `detectConfident()`: Detections with a high degree of certainty in identifying the correct file type
- `detectImprecise()`: Detections with limited supporting data, resulting in a higher likelihood of false positives
- `detectConfident()`: Detections with a high degree of certainty in identifying the correct file type.
- `detectImprecise()`: Detections with limited supporting data, resulting in a higher likelihood of false positives.
- Respect the sequence:
- Signature with shorter sample size (counted from offset 0 until the last required byte position) will be executed first.
- Only the initial determination for the file type counts for the sequence.
Expand Down

0 comments on commit e4e6228

Please sign in to comment.