fsbl: inject an appropriate DTS string for the microchip expansion board #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, these boards shipped without an embedded DTB of their own. Detect these boards by the absence of a ChipLink DTB and the presence of the Microsemi PCIe controller in ECAM space. When detected, switch the board DTB for a DTB which includes the Microsemi root complex.
tmagik
reviewed
Sep 3, 2018
There was a problem hiding this comment.
What is the downside (until we have proper overlay support, or a new bitstream) to just assume a Microsemi board exists, and letting Linux probe for the PCI root complex, rather than including two complete dtb blobs which only differ by whether they have the Microsemi entry or not?
I can't really test it anyway, as from what I can tell the image that shipped on the expansion boards has something wrong with it, so a new bitstream is going to be required to do anything useful.
|
Don't merge this. It's not ready yet. |
|
We should also try as you suggest: let the driver probe for the Microsemi PCIe if the board doesn't say anything different via ChipLink. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, these boards shipped without an embedded DTB of their own.
Detect these boards by the absence of a ChipLink DTB and the presence of
the Microsemi PCIe controller in ECAM space.
When detected, switch the board DTB for a DTB which includes the Microsemi
root complex.