Split methods into logical units and change JVM usage #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kotlin project files should be in a folder named kotlin, not java
The mono file was getting too big. The methods were split into these logical units: - Date - DateTime - Day - Time
Previously Java users would write SimpleDateKt.toDateTimeStandard(new Date()). This commit removes the Kt postfix of the generated class name.
The print lines looks like something that maybe should be moved to unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The one file for the library was getting big. I think it is easier to find what you're looking for if functionality is grouped into smaller files, especially when the library is getting bigger as it probably will. Hopefully a split like this will make it easier to navigate.
I also added JVM notations so that the usage from Java becomes
SimpleDate.toDateStandard(date)instead ofSimpleDateKt.toDateStandard(date). TheKtpostfix is now removed.Would love feedback on how to improve or discuss why this doesn't make sense.
I also remove the out-commented
printline()s. Looks like a test suite to me, and maybe we should create tests instead?