-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to NeuroLibre submission #91
Conversation
@jcohenadad just pinging you if the email for this PR slipped through the cracks |
it's on my todo list, thank you for the reminder 😊 |
This comment was marked as resolved.
This comment was marked as resolved.
it would be cool to have the fig interactive but i guess this is too time consuming to produce (tagging @nstikov so he is aware of user-facing perception of neurolibre notebook generation): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In reference to #91 (review), it would be great to use the fig generated by your notebook for the article. Notably because you fixed #90 on this repos, but the issue is still present on the original repos (hence my frustration of having the two repos out of sync @nstikov))-- what would be the best way to do it to get figs at 300dpi?
This is a Jupyter Book quirk because we’re using their bibtex rendering for the bibliographie, and @agahkarakuzu has told me before that we’re required to use this Jupyter Book biblio rendering for neurolibre submissions. The numbers indicate the different instances that the refs were cited in the text; to remove it I could limit to one citation instance per ref |
The challenge here is that I don’t think it would be possible to get an interactive Plotly figure that looks exactly this way. Plotly doesn’t have an image-visualizing tool; they refer users to their heatmap tool to display images/qMRI maps like this. The best I could achieve was to concatenate 2 subplots, but to do this with 8 may not work as desired. |
There’s an optional config that can be added to do this, i’ll let u know when its added with an example outputs (its not saved inside the script, but gives a displaybar that lets you save it to your configurated format) |
no need |
no worries (and no need to spend time on this), i mostly wanted to give feedback for @nstikov |
Updated the Plotly config to show a display bar to export a PNG: From: https://shimming-toolbox.github.io/rf-shimming-7t/ I've exported a version of the PNG, and uploaded it to the the figures folder for the manuscript (link to figure: https://drive.google.com/file/d/10uSw0ct5VATOqHcgmj8mq3FHn6qnAYs8/view?usp=sharing). If good as is, we can delete the other fig3 files. A few notes:
rf-shimming-7t/content/index.ipynb Lines 1279 to 1281 in b48b12b
changing the height/width will change the ratio, and the final number of pixels in your images will be these numbers times your scaling factor (which we set to 2 to give higher res; I find that setting the number of pixels higher directly doesn't give as good of a final image than doing it this way). |
@jcohenadad I believe I've addressed all of comments, you can have one more look here: https://shimming-toolbox.github.io/rf-shimming-7t/ Once you think this is ready for merging, I'll update all the references that point to this branch (see original post for this PR) at all locations to point to master (or is it main) instead, then it wll be ready for merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beautiful work ❤️
Resolves #42
Live link to Jupyter Book: https://shimming-toolbox.github.io/rf-shimming-7t/
Currently all the working links point to this branch for the review so that they're usable and viewable, will need to change all instances of
mb/neurolibre
tomain
prior to merging.rf-shimming-7t/README.md
Lines 4 to 5 in c223bca
rf-shimming-7t/README.md
Line 36 in c223bca
rf-shimming-7t/README.md
Line 45 in c223bca
rf-shimming-7t/.github/workflows/main.yml
Line 7 in c223bca
rf-shimming-7t/content/_config.yml
Line 19 in efcdefa
rf-shimming-7t/content/_config.yml
Line 19 in efcdefa
Will also have to move this release binary of the processed data to this repo or somewhere else that's not GDrive (they hate it when you access files too often):
rf-shimming-7t/binder/data_requirement.json
Line 2 in c223bca
or if you prefer, we can keep all of this in this branch and submit to NeuroLibre using a branch reference.
After this is merged/ready, submitting to NeuroLibre is done through their portal (must log in with ORCID first): https://neurolibre.org. It's a quick 2 minute form to fill out.