Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Eagle2]Fix multiple concurrent request crashes #2730

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

coolhok
Copy link

@coolhok coolhok commented Jan 4, 2025

Motivation

fix some Eagle2 some bug

  • hidden_states interference between multiple concurrent requests,in func (prepare_for_decode).
  • Multiple concurrent occurrences have a certain probability of crashing.when req1 is finished,req2 is comming.in func (merge_batch).
  • Multiple concurrent, add func filter_batch for handle AbortReq。

work with @jjjjohnson @bisunny

Need to rely on #2723

Modifications

  • when Multiple concurrent in func prepare_for_decode,selected_input_index need add batch offset.
  • when req1 is finished.req2 is new decode request.req1 hidden_states is none.
  • add func filter_batch for handle AbortReq.

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@coolhok coolhok changed the title [Eagle2]Some errors when dealing with multiple concurrency. [Eagle2]Fix multiple concurrent request crashes Jan 4, 2025
@zhyncs zhyncs mentioned this pull request Jan 5, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants