Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support regex as a stopping condition #2699

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mickqian
Copy link
Contributor

@mickqian mickqian commented Jan 2, 2025

Motivation

Addressing the issue #2007.

Modifications

  1. Adds stop_regex_strs field to SamplingParams
  2. Implement stop logic in Req::check_finished

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

This PR is based on top of #2035, with modifying the stopping logic.

@mickqian mickqian force-pushed the regex-stopping-condition branch from 5cdf6af to b07e7be Compare January 2, 2025 01:38
@mickqian mickqian force-pushed the regex-stopping-condition branch from b07e7be to 2fe3433 Compare January 2, 2025 01:42
@merrymercy merrymercy mentioned this pull request Jan 2, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants