Release 3.1.4

sensorsdata · Aug 30, 2021 · 33a562f · 33a562f
1 parent 90a3da5
commit 33a562f
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 10 deletions.
diff --git a/SensorsAnalyticsSDK.podspec b/SensorsAnalyticsSDK.podspec
@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name         = "SensorsAnalyticsSDK"
-  s.version      = "3.1.3"
+  s.version      = "3.1.4"
   s.summary      = "The official iOS SDK of Sensors Analytics."
   s.homepage     = "http://www.sensorsdata.cn"
   s.source       = { :git => 'https://github.com/sensorsdata/sa-sdk-ios.git', :tag => "v#{s.version}" } 

diff --git a/SensorsAnalyticsSDK/AppPush/SAAppPushManager.m b/SensorsAnalyticsSDK/AppPush/SAAppPushManager.m
@@ -28,6 +28,7 @@
 #import "SALog.h"
 #import "UIApplication+PushClick.h"
 #import "SensorsAnalyticsSDK+Private.h"
+#import "SAMethodHelper.h"
 
 #if __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_10_0
 #import "SAUNUserNotificationCenterDelegateProxy.h"
@@ -49,6 +50,9 @@ - (void)setConfigOptions:(SAConfigOptions *)configOptions {
 }
 
 - (void)proxyNotifications {
+    //处理未实现代理方法也能采集事件的逻辑
+    [SAMethodHelper swizzleRespondsToSelector];
+
     //UIApplicationDelegate proxy
     [SAApplicationDelegateProxy resolveOptionalSelectorsForDelegate:[UIApplication sharedApplication].delegate];
     [SAApplicationDelegateProxy proxyDelegate:[UIApplication sharedApplication].delegate selectors:[NSSet setWithArray:@[@"application:didReceiveLocalNotification:", @"application:didReceiveRemoteNotification:fetchCompletionHandler:"]]];

diff --git a/SensorsAnalyticsSDK/AutoTrack/SAAutoTrackManager.m b/SensorsAnalyticsSDK/AutoTrack/SAAutoTrackManager.m
@@ -31,7 +31,6 @@
 #import "UIApplication+AutoTrack.h"
 #import "UIViewController+AutoTrack.h"
 #import "SASwizzle.h"
-#import "NSObject+DelegateProxy.h"
 #import "SAAppStartTracker.h"
 #import "SAAppEndTracker.h"
 #import "SAConstants+Private.h"
@@ -275,9 +274,6 @@ - (void)enableAppClickAutoTrack {
     [UITableView sa_swizzleMethod:@selector(setDelegate:)
                        withMethod:selector
                             error:NULL];
-    [NSObject sa_swizzleMethod:@selector(respondsToSelector:)
-                    withMethod:@selector(sensorsdata_respondsToSelector:)
-                         error:NULL];
     [UICollectionView sa_swizzleMethod:@selector(setDelegate:)
                             withMethod:selector
                                  error:NULL];

diff --git a/SensorsAnalyticsSDK/Core/HookDelegate/SAMethodHelper.h b/SensorsAnalyticsSDK/Core/HookDelegate/SAMethodHelper.h
@@ -80,6 +80,10 @@ NS_ASSUME_NONNULL_BEGIN
 /// @param toClass 需要替换的方法的类
 + (IMP _Nullable)replaceInstanceMethodWithDestinationSelector:(SEL)destinationSelector sourceSelector:(SEL)sourceSelector fromClass:(Class)fromClass toClass:(Class)toClass;
 
+/// swizzle respondsToSelector 方法
+/// 用于处理未实现代理方法也能采集事件的逻辑
++ (void)swizzleRespondsToSelector;
+
 @end
 
 NS_ASSUME_NONNULL_END
diff --git a/SensorsAnalyticsSDK/Core/HookDelegate/SAMethodHelper.m b/SensorsAnalyticsSDK/Core/HookDelegate/SAMethodHelper.m
@@ -25,6 +25,8 @@
 #import "SAMethodHelper.h"
 #import <objc/runtime.h>
 #import "SALog.h"
+#import "SASwizzle.h"
+#import "NSObject+DelegateProxy.h"
 
 @implementation SAMethodHelper
 
@@ -71,4 +73,13 @@ + (IMP _Nullable)replaceInstanceMethodWithDestinationSelector:(SEL)destinationSe
     return class_replaceMethod(toClass, destinationSelector, methodIMP, types);
 }
 
++ (void)swizzleRespondsToSelector {
+    static dispatch_once_t onceToken;
+    dispatch_once(&onceToken, ^{
+        [NSObject sa_swizzleMethod:@selector(respondsToSelector:)
+                        withMethod:@selector(sensorsdata_respondsToSelector:)
+                             error:NULL];
+    });
+}
+
 @end
diff --git a/SensorsAnalyticsSDK/Core/SensorsAnalyticsSDK.m b/SensorsAnalyticsSDK/Core/SensorsAnalyticsSDK.m
@@ -41,7 +41,7 @@
 #import "SAProfileEventObject.h"
 #import "SAJSONUtil.h"
 
-#define VERSION @"3.1.3"
+#define VERSION @"3.1.4"
 
 void *SensorsAnalyticsQueueTag = &SensorsAnalyticsQueueTag;
 
@@ -331,13 +331,12 @@ - (void)login:(NSString *)loginId {
 }
 
 - (void)login:(NSString *)loginId withProperties:(NSDictionary * _Nullable )properties {
-    if (![self.identifier isValidLoginId:loginId]) {
-        return;
-    }
-
     SASignUpEventObject *object = [[SASignUpEventObject alloc] initWithEventId:kSAEventNameSignUp];
     object.dynamicSuperProperties = [self.superProperty acquireDynamicSuperProperties];
     dispatch_async(self.serialQueue, ^{
+        if (![self.identifier isValidLoginId:loginId]) {
+            return;
+        }
         [self.identifier login:loginId];
         [[NSNotificationCenter defaultCenter] postNotificationName:SA_TRACK_LOGIN_NOTIFICATION object:nil];
         [self trackEventObject:object properties:properties];