Add type for /complete data
#96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jbergler
approved these changes
Jul 20, 2023
aryx
approved these changes
Jul 20, 2023
aryx
approved these changes
Jul 25, 2023
|
I see the PR reference /complete but the .atd does not talk about it. |
Done |
mmcqd
added a commit
to semgrep/semgrep
that referenced
this pull request
Jul 25, 2023
This PR adds an ATD type for the data being sent to the `/complete` endpoint of the app. An app PR doing the same will follow. Depends on: semgrep/semgrep-interfaces#96 PR checklist: - [x] Purpose of the code is [evident to future readers](https://semgrep.dev/docs/contributing/contributing-code/#explaining-code) - [x] Tests included or PR comment includes a reproducible test plan - [x] Documentation is up-to-date - [x] A changelog entry was [added to changelog.d](https://semgrep.dev/docs/contributing/contributing-code/#adding-a-changelog-entry) for any user-facing change - [x] Change has no security implications (otherwise, ping security team) If you're unsure about any of this, please see: - [Contribution guidelines](https://semgrep.dev/docs/contributing/contributing-code)! - [One of the more specific guides located here](https://semgrep.dev/docs/contributing/contributing/) --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
|
You should talk with @mjambon when he is back from vacation about your ideas for improving ATD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the optional fields are new since
0.123.00.123.0 data: https://github.com/returntocorp/semgrep/blob/084ff5f16866ab66337655dbc06672e05d3089dc/cli/src/semgrep/app/scans.py#L301
Current data: https://github.com/returntocorp/semgrep/blob/develop/cli/src/semgrep/app/scans.py#L320
make setup && maketo update the generated code after editing a.atdfile (TODO: have a CI check)