-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dependabot): ✨ add dependabot for updating Python dependencies #444
Conversation
directory: / | ||
schedule: | ||
interval: weekly | ||
versioning-strategy: increase-if-necessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To update the version constraint in the manifest file only if the new version is not in range. Seems like some people prefer this because it leads to fewer updates on the whole, but I don't have any deeper insight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work for poetry managed projects? There is no manifest file for poetry projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I thought pyproject.toml
was the ?equivalent of the? manifest file. In any case, with increase-if-necessary
pyproject.toml
will only be updated if the new version is outside the range specified in pyproject.toml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it seems that it only updates the poetry lock file: dependabot/dependabot-core#8603 which seems to be waiting on python-poetry/poetry-core#708
Maybe we wait a bit for those PRs to be merged, since it doesn't make sense to only update the lock file and not the pyproject.toml
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, but then I'm a bit confused about why it updated both of them in my test repo (e.g. if you look at this PR). Or am I looking at the wrong thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, that is super odd... What's the open issues for then?? Well, let's just try it out and see how it works 😋😋
I read around a bit about what some sensible default settings might be, but it's still pretty bare bones, so feel free to ignore or change. I'm also not sure if any other future repos might want to use the same setup, in which case we might want it to be synced across them like some other files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I don't know much about dependabot, but I think it's nice to start implementing it :)
@lwjohnst86 should this be in the .github
repo?
Description
This PR adds dependabot and configures it to update Python dependencies (managed by Poetry) in this repository.
The PRs will look something like:
See also Issue seedcase-project/.github#24
Testing
I tested it in a minimal repo and it seemed to behave as expected.
Reviewer Focus
This PR only needs a quick review.
Checklist
For all PRs that are not general documentation