Revert "rpc stream: do not abort stream queue if stream connection was closed without error" #2618
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s closed without error" This reverts commit 27f834e. This revert fixes test failures in Seastar.unit.rpc test suite, such as: Start 47: Seastar.unit.rpc 47/79 Test scylladb#47: Seastar.unit.rpc ..............................***Timeout 300.04 sec The tests fail randomly and more frequently in debug builds.
|
@gleb-cloudius - can you please take a look? |
Looking. Not easy to reproduce, but it looks like this is test loopback implementation problem. Aborting the connection not always result in an error on the other side for some reason. |
|
FWIW, #2620 was created to track the regression in test. |
gleb-cloudius
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I'm not sure about seastar policy about reverting changes that break tests. I created the PR with hope that it will save someone time to be able to just click merge. If the policy is to fix, then of course the PR can be closed.
This reverts commit 27f834e.
This revert fixes test failures in Seastar.unit.rpc test suite, such as:
47/79 Test #47: Seastar.unit.rpc ..............................***Timeout 300.04 sec
The tests fail randomly and more frequently in debug builds.