Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provided multiple fixes of different importance #1692

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
// Set *default* container specific settings.json values on container create.
"settings": {},

// Add the IDs of extensions you want installed when the container is created.
// Add the IDs of extensions you want to be installed when the container is created.
"workspaceFolder": "/home/vscode/SecretNetwork",
"extensions": [
"bungcip.better-toml",
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/check-objdump/dist/37.index.js
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ class MultipartParser {
previousIndex = index;

if (index === 0) {
// boyer-moore derrived algorithm to safely skip non-boundary data
// boyer-moore derived algorithm to safely skip non-boundary data
i += boundaryEnd;
while (i < bufferLength && !(data[i] in boundaryChars)) {
i += boundaryLength;
Expand Down
4 changes: 2 additions & 2 deletions app/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ var (
homeDir, _ = os.UserHomeDir()
DefaultCLIHome = filepath.Join(homeDir, ".secretd")

// DefaultNodeHome sets the folder where the applcation data and configuration will be stored
// DefaultNodeHome sets the folder where the application data and configuration will be stored
DefaultNodeHome = filepath.Join(homeDir, ".secretd")

// Module accounts that are allowed to receive tokens
Expand Down Expand Up @@ -264,7 +264,7 @@ func NewSecretNetworkApp(
app.configurator = module.NewConfigurator(app.appCodec, app.BaseApp.MsgServiceRouter(), app.BaseApp.GRPCQueryRouter())
app.mm.RegisterServices(app.configurator)

// setupUpgradeHandlers() shoulbe be called after app.mm is configured
// setupUpgradeHandlers() should be called after app.mm is configured
app.setupUpgradeHandlers()

// initialize stores
Expand Down
4 changes: 2 additions & 2 deletions app/keepers/keepers.go
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ func (ak *SecretAppKeepers) CreateScopedKeepers() {
// Also, Create keepers and modules for the transfer, compute, icacontroller and icahost modules.
// These are all ibc-enabled, so we build a Stack around each of them.
//
// For example, this is how the stack will be build for the transfer app
// For example, this is how the stack will be built for the transfer app
// - SendPacket. Originates from the transferKeeper and goes up the stack:
// transferKeeper.SendPacket -> ibcpacketforward.SendPacket -> ibcfeekeeper.SendPacket ->
// - RecvPacket, message that originates from core IBC and goes down to app, the flow is the other way:
Expand Down Expand Up @@ -294,7 +294,7 @@ func (ak *SecretAppKeepers) InitCustomKeepers(
// 4. IBC Transfer should go through the IBC Hooks middleware
//
// Therefore we'll initialize the Switch keeper and pass it to the Fee keeper as an ics4wrapper.
// That means that whenever a packet is being send via Fee as an ics4wrapper, it will go through the switch middleware first (ref: https://github.com/cosmos/ibc-go/blob/v4.3.0/modules/apps/29-fee/keeper/relay.go#L15-L18).
// That means that whenever a packet is being sent via Fee as an ics4wrapper, it will go through the switch middleware first (ref: https://github.com/cosmos/ibc-go/blob/v4.3.0/modules/apps/29-fee/keeper/relay.go#L15-L18).
// Then we'll pass Fee as an ics4wrapper to everything else.
//
// Compute send: Switch -> Fee -> Packet Forward -> WASM Hooks
Expand Down
2 changes: 1 addition & 1 deletion check-hw/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ edition = "2021"
default = []
production = []

# Just here for compatability with enclave features
# Just here for compatibility with enclave features
verify-validator-whitelist = []
light-client-validation = []
random = []
Expand Down
14 changes: 7 additions & 7 deletions client/docs/swagger_legacy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ paths:
tags:
- Deprecated API
deprecated: true
description: Get if the node is currently syning with other nodes
description: Get if the node is currently syncing with other nodes
produces:
- application/json
responses:
Expand Down Expand Up @@ -435,7 +435,7 @@ paths:
$ref: "#/definitions/Coin"
responses:
202:
description: Tx was succesfully generated
description: Tx was successfully generated
schema:
$ref: "#/definitions/StdTx"
400:
Expand Down Expand Up @@ -520,7 +520,7 @@ paths:
sequence:
type: string
500:
description: Server internel error
description: Server internal error
/staking/delegators/{delegatorAddr}/delegations:
parameters:
- in: path
Expand Down Expand Up @@ -773,7 +773,7 @@ paths:
- application/json
responses:
200:
description: Tx was succesfully generated
description: Tx was successfully generated
schema:
$ref: "#/definitions/StdTx"
400:
Expand Down Expand Up @@ -1065,7 +1065,7 @@ paths:
$ref: "#/definitions/StdTx"
responses:
200:
description: Tx was succesfully generated
description: Tx was successfully generated
schema:
$ref: "#/definitions/StdTx"
400:
Expand Down Expand Up @@ -1138,7 +1138,7 @@ paths:
$ref: "#/definitions/Coin"
responses:
200:
description: Tx was succesfully generated
description: Tx was successfully generated
schema:
$ref: "#/definitions/StdTx"
400:
Expand Down Expand Up @@ -1219,7 +1219,7 @@ paths:
$ref: "#/definitions/ParamChange"
responses:
200:
description: The transaction was succesfully generated
description: The transaction was successfully generated
schema:
$ref: "#/definitions/StdTx"
400:
Expand Down
Loading