Switch to iso2 codes #524
Switch to iso2 codes #524
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
| "Russian": NSLocalizedString("app._global.russian", value: "Russian", comment: ""), | ||
| "Spanish": NSLocalizedString("app._global.spanish", value: "Spanish", comment: ""), | ||
| "Swedish": NSLocalizedString("app._global.swedish", value: "Swedish", comment: "") | ||
| "EN": NSLocalizedString("app._global.en", value: "EN", comment: ""), |
There was a problem hiding this comment.
These lines here need to be reverted to what they were as they're referencing data coming from Scribe-i18n :) No stress as there's little way for you to know this, @helocordi!
There was a problem hiding this comment.
These lines here need to be reverted to what they were as they're referencing data coming from Scribe-i18n :) No stress as there's little way for you to know this, @helocordi!
Ok I'll change that
|
Initial glances are looking really good, @helocordi! We'll try to bring this in in the comings days :) Can you fix the comment above? |
Perfect, I've changed it now :) |
There was a problem hiding this comment.
Ultimately we do did need to revert the changes to the controller language references as I forgot that those are coming directly from the settings for each keyboard. We could switch it over, but then in thinking as well there might be some pros to the full language as strings as there will one day be languages that people are not sure on for the iso-2 code 😊 As it stands now, we're changing variable names to just use iSO-2 codes, which further matches the file names. I'd say this is great 😊
Thanks for the great contribution, @helocordi!
Contributor checklist
xcodebuildandswiftlint --strictcommands as directed in the testing section of the contributing guideDescription
In response to issue #494, I've switched every single reference to a language to ISO-2 code.
"Danish": "da",
"English": "en",
"French": "fr",
"German": "de",
"Italian": "it",
"Norwegian": "nb",
"Portuguese": "pt",
"Russian": "ru",
"Spanish": "es",
"Swedish": "sv"
It still needs to be tested a bit to ensure that the change doesn't lead to new errors.
Related issue