Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade dependencies and remove unnecessary dependencies #43

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

felixranesberger
Copy link
Collaborator

@felixranesberger felixranesberger commented Oct 4, 2024

This pull request changes quite a few things.
The main goal was to upgrade glob from v7 to a newer version, since all versions below v9 throw an warning on install that the version is outdated.

While doing that I also upgraded and changed a few things:

  • Upgraded glob version in kss-scheibo
  • Depend on new version of scheibo kss-node fork that removes bluebird and updates fs-extra and glob
    see: feat: upgrade glob from v7 to v11 kss-node#2
  • Removed bluebird since glob and fs-extra now fully support promises.
  • Upgraded browser-sync since the old version depends on old glob version
  • Removed eslint, since it wasn't really used or working anyway
  • Removed jshint since it was quite old, the rules outdated and used legacy glob as a dependency
  • Upgraded browser-sync as it depended on old glob version

When creating a new test styleguide using the new changes, I got the same results and no errors, so everything should work as expected.

@felixranesberger felixranesberger changed the title feat(wip): upgrade dependencies feat(wip): upgrade dependencies and remove additional dependencies Oct 4, 2024
@felixranesberger felixranesberger changed the title feat(wip): upgrade dependencies and remove additional dependencies feat: upgrade dependencies and remove additional dependencies Oct 4, 2024
@felixranesberger felixranesberger changed the title feat: upgrade dependencies and remove additional dependencies feat: upgrade dependencies and remove unnecessary dependencies Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant