Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Travis-CI instructions #341

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Dec 19, 2024

It's a GitHub Actions world these days.

I left the FAQ entry about other CI systems in place, and it now covers Travis-CI briefly.

If someone thinks the Travis-CI instructions should remain in-repo, I would suggest that they volunteer to reinstate them in a separate file (UPDATE: or in the FAQ entry, if they're short enough? just not sprinkled throughout!) in a separate PR.

At one time, it made sense for the readme to contain instructions for both CI systems inline. With GitHub Actions now so dominant, I feel rather strongly that it's too annoying for the reader to have to skip over the Travis-CI material.

@eed3si9n
Copy link
Member

We got a PR to organize Travis CI related doc fairly recently - #310

@SethTisue
Copy link
Member Author

SethTisue commented Dec 19, 2024

interesting. I wonder how many other @bcarter97 s there are out there.

@bcarter97
Copy link
Contributor

@SethTisue not many I think, we are having a fair few issues with Travis.

@SethTisue
Copy link
Member Author

SethTisue commented Jan 6, 2025

@eed3si9n up/down decision? I'm still hoping for a merge here. it's an annoyance to 95% (maybe 99%) of our users to have to skip over this stuff in the doc. documenting alternative CI systems is worthwhile, but shouldn't get in the way of normal usage.

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok let's rip it out

@eed3si9n eed3si9n merged commit 30f2a17 into sbt:main Jan 7, 2025
2 checks passed
@SethTisue SethTisue deleted the remove-travis-instructions branch January 7, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants