Add support for SAUCE_USERNAME and SAUCE_ACCESS_KEY #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omacranger
reviewed
Mar 18, 2024
ebekebe
approved these changes
Mar 18, 2024
| @@ -47,6 +66,11 @@ public VisualClient(WebDriver wd, Region region, string username, string accessK | |||
| /// <param name="buildOptions">the options of the build creation</param> | |||
| public VisualClient(WebDriver wd, Region region, string username, string accessKey, CreateBuildOptions buildOptions) | |||
There was a problem hiding this comment.
nice to have:
we need to add a description for rest parameters here.
There was a problem hiding this comment.
Which rest parameters are you mentioning ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Add support for
SAUCE_USERNAMEandSAUCE_ACCESS_KEYDescription
Add support for
SAUCE_USERNAMEandSAUCE_ACCESS_KEYTypes of Changes