Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify VisualClient Interface #2

Merged
merged 6 commits into from
Mar 14, 2024
Merged

Simplify VisualClient Interface #2

merged 6 commits into from
Mar 14, 2024

Conversation

FriggaHel
Copy link
Contributor

One-line summary

Simplify VisualClient Interface

Description

Hide CreateBuild/FinishBuild build logic as it's not necessary for customer.
Expose Build through VisualClient.

Rely on IDisposable interface.

Types of Changes

What types of changes does your code introduce? Keep the ones that apply:

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Configuration change
  • Refactor/improvements
  • Documentation / non-code

Tasks

List of tasks you will do to complete the PR

  • Created Task 1
  • Created Task 2
  • To-do Task 3

Review

List of tasks the reviewer must do to review the PR

  • Tests
  • Documentation
  • CHANGELOG

Deployment Notes

These should highlight any db migrations, feature toggles, etc.

@FriggaHel FriggaHel requested a review from konraddysput March 14, 2024 11:41
@FriggaHel FriggaHel requested a review from konraddysput March 14, 2024 14:30
@FriggaHel FriggaHel merged commit d8792f6 into main Mar 14, 2024
2 checks passed
@FriggaHel FriggaHel deleted the simplify-api-disposible branch March 14, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants