-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS] Add ability to assert against visual results, Add upload retry #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sults in a playwright run expose additional options for playwright snapshots keep track of current test context / execution to assert visual results in Playwright
konraddysput
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just in case, I think we should get additional check from @ebekebe or @paweltomaszewskisaucelabs
ebekebe
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
omacranger
changed the title
[Playwright] Add ability to assert against visual results
[JS] Add ability to assert against visual results, Add upload retry
Oct 15, 2024
ebekebe
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to assert against Sauce Visual results during test executions on Playwright and unifies the code for other frameworks already utilizing it.
Can either use the
sauceVisual.visualResults()
fixture orsauceVisualResults
function directly to get the result summary for an individual test and make assertions on it like what is available in Cypress / WDIO.Ex:
This also adds a retry mechanism for DOM / Snapshot uploads to GCS.
Types of Changes