Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure build is shared across all test classes #12

Merged
merged 30 commits into from
Mar 29, 2024

Conversation

FriggaHel
Copy link
Contributor

@FriggaHel FriggaHel commented Mar 25, 2024

One-line summary

Issue : IRIS-856

Description

Currently build is created (or loaded) upon creation of the VisualClient.
This PR comes to persist the newly created build, thus allowing multiple class to be reported within the same VisualBuild.

As a consequence, the Cleanup will need to be moved out of the test AfterAll, but to a global AfterAll.

Additionally:

  • Fixes a bug in the TextContext implementation
  • Removes dependency of VisualApi to WebDriver as it's never used

Types of Changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)

@FriggaHel FriggaHel changed the title Ensure build is shared across all classes Ensure build is shared across all test classes Mar 25, 2024
@FriggaHel FriggaHel requested a review from konraddysput March 27, 2024 17:05
@FriggaHel FriggaHel marked this pull request as ready for review March 27, 2024 20:29
visual-dotnet/SauceLabs.Visual/BuildFactory.cs Outdated Show resolved Hide resolved
visual-dotnet/SauceLabs.Visual/BuildFactory.cs Outdated Show resolved Hide resolved
visual-dotnet/SauceLabs.Visual/BuildFactory.cs Outdated Show resolved Hide resolved
visual-dotnet/SauceLabs.Visual/VisualBuild.cs Show resolved Hide resolved
visual-dotnet/SauceLabs.Visual/VisualCheckOptions.cs Outdated Show resolved Hide resolved
visual-dotnet/SauceLabs.Visual/VisualClient.cs Outdated Show resolved Hide resolved
@FriggaHel FriggaHel requested a review from konraddysput March 28, 2024 15:56
visual-dotnet/SauceLabs.Visual/BuildFactory.cs Outdated Show resolved Hide resolved
visual-dotnet/SauceLabs.Visual/BuildFactory.cs Outdated Show resolved Hide resolved
visual-dotnet/SauceLabs.Visual/VisualCheckOptions.cs Outdated Show resolved Hide resolved
@FriggaHel FriggaHel merged commit 11350fb into main Mar 29, 2024
2 checks passed
@FriggaHel FriggaHel deleted the IRIS-856-ensure-uniq-build branch March 29, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants