Return type

saucelabs · Jul 2, 2024 · b6d5d6f · b6d5d6f
1 parent c9b413e
commit b6d5d6f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/...t/SauceLabs.Visual/Utils/IgnoreRegions.cs → .../SauceLabs.Visual/Utils/IgnoredRegions.cs b/...t/SauceLabs.Visual/Utils/IgnoreRegions.cs → .../SauceLabs.Visual/Utils/IgnoredRegions.cs
@@ -6,10 +6,13 @@
 
 namespace SauceLabs.Visual.Utils
 {
-    internal class IgnoreRegions
+    internal class IgnoredRegions
     {
+        internal RegionIn[] RegionsIn;
+        internal ElementIn[] ElementsIn;
 
-        internal static void SplitIgnoredRegions(SelectiveRegion[]? regions, IgnoreRegion[]? ignoreRegions, IWebElement[]? ignoreElements, out RegionIn[] regionIns, out ElementIn[] elementIns)
+
+        internal static IgnoredRegions SplitIgnoredRegions(SelectiveRegion[]? regions, IgnoreRegion[]? ignoreRegions, IWebElement[]? ignoreElements)
         {
             var emptyRegions = regions?.Any(r => r.Region == null && r.Element == null);
             if (emptyRegions != null && emptyRegions != false)
@@ -25,8 +28,7 @@ internal static void SplitIgnoredRegions(SelectiveRegion[]? regions, IgnoreRegio
             ignoredElements.AddRange(ignoreElements?.Select(elem => new ElementIn(elem)) ?? new List<ElementIn>());
             ignoredElements.AddRange(regions?.Where(r => r.Element != null).Select(r => r.ToElementIn()) ?? new List<ElementIn>());
 
-            regionIns = ignoredRegions.ToArray();
-            elementIns = ignoredElements.ToArray();
+            return new IgnoredRegions { RegionsIn = ignoredRegions.ToArray(), ElementsIn = ignoredElements.ToArray() };
         }
     }
 }
diff --git a/visual-dotnet/SauceLabs.Visual/VisualClient.cs b/visual-dotnet/SauceLabs.Visual/VisualClient.cs
@@ -141,7 +141,7 @@ public Task<string> VisualCheck(string name, VisualCheckOptions? options = null,
 
         private async Task<string> VisualCheckAsync(string name, VisualCheckOptions options)
         {
-            IgnoreRegions.SplitIgnoredRegions(options.Regions, options.IgnoreRegions, options.IgnoreElements, out var ignoredRegions, out var ignoredElements);
+            var ignoredRegions = IgnoredRegions.SplitIgnoredRegions(options.Regions, options.IgnoreRegions, options.IgnoreElements);
 
             FullPageConfigIn? fullPageConfigIn = null;
             if (options.FullPage == true)
@@ -154,8 +154,8 @@ private async Task<string> VisualCheckAsync(string name, VisualCheckOptions opti
                 name: name,
                 jobId: _jobId,
                 diffingMethod: options.DiffingMethod ?? DiffingMethod.Simple,
-                regions: ignoredRegions,
-                ignoredElements: ignoredElements,
+                regions: ignoredRegions.RegionsIn,
+                ignoredElements: ignoredRegions.ElementsIn,
                 sessionId: _sessionId,
                 sessionMetadata: _sessionMetadataBlob ?? "",
                 captureDom: options.CaptureDom ?? CaptureDom,