[Cypress] Allow multiple elements in ignoreRegions (#145)

Co-authored-by: Logan Graham <[email protected]>
saucelabs · Oct 1, 2024 · 4d79c86 · 4d79c86
1 parent 2e5f7bd
commit 4d79c86
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/visual-js/.changeset/old-mails-sin.md b/visual-js/.changeset/old-mails-sin.md
@@ -0,0 +1,5 @@
+---
+"@saucelabs/cypress-visual-plugin": patch
+---
+
+fix ignore regions for multiple elements
diff --git a/visual-js/visual-cypress/src/commands.ts b/visual-js/visual-cypress/src/commands.ts
@@ -92,19 +92,13 @@ function chainableWaitForAll<S>(
 ): Cypress.Chainable<S[]> {
   const result: S[] = [];
 
-  if (list.length < 1) return cy.wrap<S[]>([]);
-
-  let curChainable = list[0];
-  for (let idx = 1; idx < list.length; idx++) {
-    curChainable = curChainable.then((resolved) => {
-      result.push(resolved);
-      return list[idx];
+  list.forEach((item) => {
+    item.then((el) => {
+      result.push(el);
     });
-  }
-  return curChainable.then((item) => {
-    result.push(item);
-    return result;
   });
+
+  return cy.wrap(result);
 }
 
 const sauceVisualCheckCommand = (