Cleanup code

saucelabs · May 3, 2024 · 121eb50 · 121eb50
1 parent a96e3ef
commit 121eb50
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/visual-java/src/main/java/com/saucelabs/visual/VisualApi.java b/visual-java/src/main/java/com/saucelabs/visual/VisualApi.java
@@ -396,22 +396,24 @@ private DiffingOptionsIn.Builder setDiffingOptionValue(
 
   private DiffingOptionsIn generateDiffingOptions(
       List<String> enableOnly, List<String> disableOnly) {
-    if (enableOnly != null && !enableOnly.isEmpty()) {
-      DiffingOptionsIn.Builder builder = DiffingOptionsIn.builder();
+    if (enableOnly != null && disableOnly != null) {
+      return null;
+    }
+
+    DiffingOptionsIn.Builder builder = DiffingOptionsIn.builder();
+
+    if (enableOnly != null) {
       for (String option : DiffingOptionValues) {
         setDiffingOptionValue(builder, option, enableOnly.contains(option));
       }
-      return builder.build();
     }
 
-    if (disableOnly != null && !disableOnly.isEmpty()) {
-      DiffingOptionsIn.Builder builder = DiffingOptionsIn.builder();
+    if (disableOnly != null) {
       for (String option : DiffingOptionValues) {
         setDiffingOptionValue(builder, option, !disableOnly.contains(option));
       }
-      return builder.build();
     }
-    return null;
+    return builder.build();
   }
 
   private static DiffingMethod toDiffingMethod(CheckOptions options) {