comments

saucelabs · Nov 27, 2024 · 0ea41b6 · 0ea41b6
1 parent 6a38c84
commit 0ea41b6
Show file tree

Hide file tree

Showing 4 changed files with 69 additions and 2 deletions.
diff --git a/visual-java/src/main/java/com/saucelabs/visual/CheckOptions.java b/visual-java/src/main/java/com/saucelabs/visual/CheckOptions.java
@@ -21,6 +21,33 @@ public enum DiffingMethod {
 
   public CheckOptions() {}
 
+  public CheckOptions(
+      List<WebElement> ignoreElements,
+      List<IgnoreRegion> ignoreRegions,
+      List<VisualRegion> regions,
+      String testName,
+      String suiteName,
+      DiffingMethod diffingMethod,
+      DiffingOptionsIn diffingOptions,
+      Boolean captureDom,
+      String clipSelector,
+      WebElement clipElement,
+      FullPageScreenshotConfig fullPageScreenshotConfig) {
+    this(
+        ignoreElements,
+        ignoreRegions,
+        regions,
+        testName,
+        suiteName,
+        diffingMethod,
+        diffingOptions,
+        captureDom,
+        clipSelector,
+        clipElement,
+        fullPageScreenshotConfig,
+        new ArrayList<>());
+  }
+
   public CheckOptions(
       List<WebElement> ignoreElements,
       List<IgnoreRegion> ignoreRegions,

diff --git a/...-java/src/main/java/com/saucelabs/visual/graphql/CreateSnapshotFromWebDriverMutation.java b/...-java/src/main/java/com/saucelabs/visual/graphql/CreateSnapshotFromWebDriverMutation.java
@@ -54,6 +54,29 @@ public static class CreateSnapshotFromWebDriverIn {
 
     public Optional<DiffingOptionsIn> diffingOptions = Optional.empty();
 
+    public CreateSnapshotFromWebDriverIn(
+        String buildUuid,
+        DiffingMethod diffingMethod,
+        Optional<DiffingOptionsIn> diffingOptions,
+        List<RegionIn> ignoreRegions,
+        List<ElementIn> ignoreElements,
+        String jobId,
+        String name,
+        String sessionId,
+        String sessionMetadata) {
+      this(
+          buildUuid,
+          diffingMethod,
+          diffingOptions,
+          ignoreRegions,
+          ignoreElements,
+          jobId,
+          name,
+          sessionId,
+          sessionMetadata,
+          new ArrayList<>());
+    }
+
     public CreateSnapshotFromWebDriverIn(
         String buildUuid,
         DiffingMethod diffingMethod,

diff --git a/visual-java/src/main/java/com/saucelabs/visual/model/FullPageScreenshotConfig.java b/visual-java/src/main/java/com/saucelabs/visual/model/FullPageScreenshotConfig.java
@@ -16,6 +16,23 @@ public class FullPageScreenshotConfig {
   private String scrollElement;
   private SelectorIn nativeClipSelector;
 
+  public FullPageScreenshotConfig(
+      int delayAfterScrollMs,
+      Boolean disableCSSAnimation,
+      List<String> hideAfterFirstScroll,
+      Boolean hideScrollBars,
+      int scrollLimit,
+      String scrollElement) {
+    this(
+        delayAfterScrollMs,
+        disableCSSAnimation,
+        hideAfterFirstScroll,
+        hideScrollBars,
+        scrollLimit,
+        scrollElement,
+        null);
+  }
+
   public FullPageScreenshotConfig(
       int delayAfterScrollMs,
       Boolean disableCSSAnimation,

diff --git a/visual-js/.changeset/shy-bananas-speak.md b/visual-js/.changeset/shy-bananas-speak.md
@@ -1,5 +1,5 @@
 ---
-"@saucelabs/nightwatch-sauce-visual-service": patch
+"@saucelabs/nightwatch-sauce-visual-service": minor
 ---
 
-ignore selectors
+add support for ignore selectors in visual check