Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLASMA-4255: Move "rc-tree/assets/index.css" to Tree.styles.js #1710

Merged
merged 1 commit into from
Jan 22, 2025
Merged

PLASMA-4255: Move "rc-tree/assets/index.css" to Tree.styles.js #1710

merged 1 commit into from
Jan 22, 2025

Conversation

vadim-kudr
Copy link
Contributor

@vadim-kudr vadim-kudr commented Jan 20, 2025 •
edited
Loading

Core

Tree

  • перенесен внешний css из rc-tree в локальную сборку

What/why changed

исправлена сборка css

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1710/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website: https://plasma.sberdevices.ru/pr/pr-1710/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1710/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1710/b2c-storybook/
giga storybook: https://plasma.sberdevices.ru/pr/pr-1710/giga-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1710/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1710/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1710/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1710/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1710/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1710/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1710/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1710/ui-storybook/

@vadim-kudr vadim-kudr self-assigned this Jan 21, 2025
@vadim-kudr vadim-kudr added the bugs Something isn't working label Jan 21, 2025
@vadim-kudr vadim-kudr marked this pull request as ready for review January 21, 2025 08:29
@github-actions github-actions bot requested review from shuga2704 and TitanKuzmich and removed request for Yeti-or, Yakutoc, neretin-trike, TitanKuzmich and shuga2704 January 21, 2025 08:29
@Yakutoc Yakutoc removed the request for review from shuga2704 January 21, 2025 16:39
@Yakutoc Yakutoc removed the bugs Something isn't working label Jan 22, 2025
@Yakutoc
Copy link
Collaborator

Yakutoc commented Jan 22, 2025

@vadim-kudr FYI

Проверки для данный ветки

  • cборка для проекта на webpack без css-loader - done
  • cборка для проекта на webpack + работ tree shaking - done
  • запуск cypress + webpack без css-loader - done
  • запуск cypress + webpack без css-loader + dev ветка - failed (ожидаемый результат)

@vadim-kudr vadim-kudr added this pull request to the merge queue Jan 22, 2025
Merged via the queue into dev with commit 062e882 Jan 22, 2025
33 checks passed
@vadim-kudr vadim-kudr deleted the PLASMA-4255 branch January 22, 2025 08:36
@Salute-Eva Salute-Eva mentioned this pull request Jan 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

@neretin-trike neretin-trike neretin-trike approved these changes

Assignees

@vadim-kudr vadim-kudr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vadim-kudr @Yakutoc @neretin-trike @TitanKuzmich