-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hideOnComplete added to allow the timer to stay visible, even after completion! #14
Conversation
Also, lemme know if you don't plan to incorporate this and I'll publish a separate npm module with the functionality, we can't deploy as is! |
@liquidg3 thank you for your PR. I was also thinking of adding this feature in the next release. By default, the clock will be hidden if children are none (at the current version v1.4.1). It seems that the changes made in your PR have caused an issue with backward compatibility when compared to the previous versions. And I don't want to make a major change just for this feature. In my opinion, it would be better if we add another boolean property (e.g. What do you think about it? Let me know your opinion, we can discuss to find the best solution. |
…ts to true to maintain legacy
@sLeeNguyen - ok, done! Lemme know what you think! 🙌🙌🙌 |
Oh, I realized I missed the have a discussion part. We're demoing tomorrow and getting this in would mean I don't have to speak to it disappearing. Thanks so much dude!! |
@sLeeNguyen demoing today. I can publish something new to npm if the timing is bad for you. I tried linking locally and that didn't work, I'll try that before publishing. But, would way prefer to use your component and continue to benefit from any enhancements. |
@liquidg3 sorry for the delay. I'm going to check it now. |
Everything looks fine. Thank you for your contribution |
@sLeeNguyen - is that fail related to yarn cache failing? lemme know if I can help with any failed/checks/etc. |
it's ok. Ready to merge now |
@sLeeNguyen woohoo! Thanks so much! As soon as a new version is published I'll give it a shot and if I get a chance film it in action so you can see it!! |
I'm doing local check now. I will inform you when it's done |
@liquidg3 I've just released v1.5.0. Lemme know if there are any problem |
Case:
It was the intuition of the team that the counter would stay at zero unless a completion component was set. This change adds a new feature, which is essentially (hang at zero) while maintaining the old functionality of showing a completion component if one is set.
Notes:
I added a test, kept original ones working. BUT, it did require me to
npm install postcss-present-env
to get the react example to work. My assumption is that you have it globally installed on your dev machine.Conclusion:
Great work! Easiest the best looking flip style timer out there!