-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nvrs #1865
base: main
Are you sure you want to change the base?
Add nvrs #1865
Conversation
nvrs has over 2000 downloads on crates.io. No idea why the CI is failing. |
CI is failing because it only looks at the text in the README not PR and there isn't a magic way to go from a repo link to a crates page. You'll need to add the crates link to the README in line with the other links. |
and i'm 99% sure there is a magic way to go from a repo link to crates.io page. crates.io use the |
The crates.io link has to be on the Readme of Awasome Rust (e.g. the target file of this PR), not in the project's own readme. So the crates.io is link missing in the content of PR and hence the build is failing. The format is explained on CONTRIBUTING, but in essense it's:
|
AFAIK, the crates.io search interface doesn't provide this even if the repo code does. Even if such a thing did exist, it's not present in the automated checker code for this repository, so you'll need to add the crates URL manually. Patches are welcomed to the automated checker code if you want to improve this in a separate PR. |
https://github.com/adamperkowski/nvrs
https://crates.io/crates/nvrs