Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nvrs #1865

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add nvrs #1865

wants to merge 2 commits into from

Conversation

adamperkowski
Copy link
Contributor

@adamperkowski
Copy link
Contributor Author

nvrs has over 2000 downloads on crates.io. No idea why the CI is failing.

@palfrey
Copy link
Collaborator

palfrey commented Dec 29, 2024

nvrs has over 2000 downloads on crates.io. No idea why the CI is failing.

CI is failing because it only looks at the text in the README not PR and there isn't a magic way to go from a repo link to a crates page. You'll need to add the crates link to the README in line with the other links.

@adamperkowski
Copy link
Contributor Author

adamperkowski commented Dec 29, 2024

CI is failing because it only looks at the text in the README not PR and there isn't a magic way to go from a repo link to a crates page. You'll need to add the crates link to the README in line with the other links.

i do:
https://github.com/adamperkowski/nvrs/blob/d20bfb39888ae0a65e7478fc588e0889e8c80154/README.md?plain=1#L67

and i'm 99% sure there is a magic way to go from a repo link to crates.io page. crates.io use the repository field in Cargo.toml.
and there still is the search accessible from the API and crate IDs.

@35VLG84
Copy link
Contributor

35VLG84 commented Dec 29, 2024

The crates.io link has to be on the Readme of Awasome Rust (e.g. the target file of this PR), not in the project's own readme. So the crates.io is link missing in the content of PR and hence the build is failing.

The format is explained on CONTRIBUTING, but in essense it's:

  • Template: [ACCOUNT/REPO](https://github.com/ACCOUNT/REPO) [[CRATE](https://crates.io/crates/CRATE)] - DESCRIPTION

@palfrey
Copy link
Collaborator

palfrey commented Dec 31, 2024

and i'm 99% sure there is a magic way to go from a repo link to crates.io page. crates.io use the repository field in Cargo.toml. and there still is the search accessible from the API and crate IDs.

AFAIK, the crates.io search interface doesn't provide this even if the repo code does. Even if such a thing did exist, it's not present in the automated checker code for this repository, so you'll need to add the crates URL manually. Patches are welcomed to the automated checker code if you want to improve this in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants