feat: hide successful policy check results when --quiet-policy-checks is set with multiple projects #5168
+558
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joec4i
requested review from
jamengual,
lukemassa and
X-Guardian
and removed request for
a team
dosubot
bot
added
feature
joec4i
force-pushed
the
quiet-policy-check-improvement
branch
from
d2b193e to
b22a3aa
Compare
github-actions
bot
added
build
joec4i
force-pushed
the
quiet-policy-check-improvement
branch
from
b22a3aa to
d092a44
Compare
joec4i
changed the title
|
Thanks for this @joec4i. Can you add before and after example results to the PR description as evidence of your change. |
X-Guardian
added
waiting-on-response
|
Thanks for reviewing this, @X-Guardian . I've uploaded two screenshots to show the difference. This was taken from our test repo with two test projects. The noise reduction will be even more noticeable in repositories with more projects, which is common for Terraform setups supporting multiple environments. Looking forward to your feedback! |
X-Guardian
requested changes
Dec 18, 2024
joec4i
force-pushed
the
quiet-policy-check-improvement
branch
2 times, most recently
from
02a462c to
26a07a5
Compare
…t with multiple projects Signed-off-by: Joe Cai <[email protected]>
…sistency Signed-off-by: Joe Cai <[email protected]>
joec4i
force-pushed
the
quiet-policy-check-improvement
branch
from
26a07a5 to
c118111
Compare
|
Thanks again for your review, @X-Guardian . I've updated the test cases. Please have another look! Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Improve the
--quiet-policy-checksflag to only display unsuccessful policy check results when multiple projects are involved.why
Currently, the
--quiet-policy-checksflag is effective for a single project or when all policy checks pass across multiple projects. However, when there are multiple projects involved, it becomes noisy when one or more checks fail, as it shows both successful and unsuccessful results. This PR hides successful check results when--quiet-policy-checksis specified in order to reduce noise and allow users to focus on failed checks.tests
Before
Note: the bot's username is masked.
After
references