chore: minor improvements 2

rudderlabs · Jan 3, 2025 · cb0f336 · cb0f336
1 parent 69ac89b
commit cb0f336
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/packages/analytics-js/src/components/capabilitiesManager/CapabilitiesManager.ts b/packages/analytics-js/src/components/capabilitiesManager/CapabilitiesManager.ts
@@ -205,11 +205,7 @@ class CapabilitiesManager implements ICapabilitiesManager {
    * @param error The error object
    */
   onError(error: unknown): void {
-    if (this.errorHandler) {
-      this.errorHandler.onError(error, CAPABILITIES_MANAGER);
-    } else {
-      throw error;
-    }
+    this.errorHandler.onError(error, CAPABILITIES_MANAGER);
   }
 }
 

diff --git a/packages/analytics-js/src/components/eventRepository/EventRepository.ts b/packages/analytics-js/src/components/eventRepository/EventRepository.ts
@@ -211,7 +211,6 @@ class EventRepository implements IEventRepository {
    * Handles error
    * @param error The error object
    * @param customMessage a message
-   * @param shouldAlwaysThrow if it should throw or use logger
    */
   onError(error: unknown, customMessage?: string): void {
     if (this.errorHandler) {