Remove Clearance from UsersController. #4201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4201 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 336 336
Lines 7416 7417 +1
=======================================
+ Hits 7322 7323 +1
Misses 94 94 ☔ View full report in Codecov by Sentry. |
simi
force-pushed
the
clearance-sunset-1
branch
3 times, most recently
from
edde9f6 to
b414ef0
Compare
segiddins
reviewed
Nov 12, 2023
|
@simi what's the status on this? |
I'll fix #4201 (comment) for now and I'm happy to merge. |
- it is not used, since it is overridden
simi
force-pushed
the
clearance-sunset-1
branch
from
b414ef0 to
4b449ba
Compare
segiddins
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idea behind
Clearance seems not used as originally intended currently. It is based around email/password and provides various helpers. But some of them were already merged into Rails and some of them doesn't work anymore for RubyGems.org since MFA/OTP/WebAuthN... Considering it is sometimes blocking upgrades (thoughtbot/clearance#995) it is IMHO good time to reconsider its usage. At various places it is already overridden and not used.
I do kick-off with off-boarding
ClearancefromUsersController. Is is possible to also removeinclude Clearance::AuthorizationfromApplicationControllersince it is useful only forredirect_back_orhelper which is already present in Rails these days asredirect_back_or_to. In following PRs I would like to address other controllers and finally theUsermodel.