generated from actions/javascript-action
-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes the latest rubygems installation error with Ruby 3.0 #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watson1978
force-pushed
the
latest-rubygems
branch
2 times, most recently
from
December 19, 2024 02:34
c8ac511
to
34c9234
Compare
If set up `rubygems: latest` in workflow, it will cause the error with Ruby 3.0 because the latest rubygems does not support Ruby 3.0. Ref. https://rubygems.org/gems/rubygems-update ### Error message ``` Updating RubyGems /opt/hostedtoolcache/Ruby/3.0.7/x64/bin/gem --version 3.2.33 Default RubyGems version is 3.2.33 Updating RubyGems to latest version /opt/hostedtoolcache/Ruby/3.0.7/x64/bin/gem update --system ERROR: Error installing rubygems-update: rubygems-update-3.6.1 requires Ruby version >= 3.1.0. The current ruby version is 3.0.7.220. ERROR: While executing gem ... (NoMethodError) undefined method `version' for nil:NilClass Updating rubygems-update Took 2.86 seconds Error: The process '/opt/hostedtoolcache/Ruby/3.0.7/x64/bin/gem' failed with exit code 1 ``` ### How to reproduce ``` uses: ruby/setup-ruby@v1 with: ruby-version: "3.0" rubygems: latest ```
Watson1978
force-pushed
the
latest-rubygems
branch
from
December 19, 2024 02:39
34c9234
to
b23e211
Compare
eregon
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@eregon Could you please merge & release this PR ? |
MSP-Greg
added a commit
to MSP-Greg/puma
that referenced
this pull request
Dec 22, 2024
MSP-Greg
added a commit
to puma/puma
that referenced
this pull request
Dec 22, 2024
Done, I was waiting CI then forgot |
MSP-Greg
added a commit
to MSP-Greg/puma
that referenced
this pull request
Dec 23, 2024
This reverts commit ca90050.
MSP-Greg
added a commit
to puma/puma
that referenced
this pull request
Dec 23, 2024
This reverts commit ca90050.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If set up
rubygems: latest
in workflow,it will cause the error with Ruby 3.0 because the latest rubygems does not support Ruby 3.0.
Ref. https://rubygems.org/gems/rubygems-update
Error message
How to reproduce