Prevent cursor flickering in dancing ruby #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ima1zumi
changed the title
tompng
reviewed
Nov 30, 2024
lib/irb/easter-egg.rb
Outdated
| @@ -142,6 +143,7 @@ def render_frame(i) | |||
| end | |||
| end | |||
| ensure | |||
| print "\e[?25h" # show cursor | |||
There was a problem hiding this comment.
print "\e[?25l" is written inside STDOUT.cooked do end how about move this to the ensure statement of STDOUT.cooked do ensure end?
There was a problem hiding this comment.
Good point, I've fixed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
The cursor appears in the bottom right corner and occasionally flickers.
CleanShot.2024-12-01.at.00.49.00.mp4
After
CleanShot.2024-12-01.at.00.47.26.mp4