-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: abstract types to shared package #1593
Conversation
🦋 Changeset detectedLatest commit: 8508bed The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@eoghanmurray just went to do it there but looks like you got there ahead of me :) |
Not sure why the bot isn't picking up that there's a changeset; it seemed to have failed when I added it with the changeset-bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing all this work @daibhin! This will make landing the asset PRs that @eoghanmurray and I have been working on a lot less painful
… dn-chore/type-changes
Abstracted all the shared types from the
rrweb-snapshot
project into the shared@rrweb/types
package as was done in #1475Additional context in https://rrweb.slack.com/archives/C0614SW58TW/p1730134366873209