feat: add CI for publishing chrome extension #1568
Conversation
🦋 Changeset detectedLatest commit: d09f561 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| - uses: mnao305/[email protected] | ||
| with: | ||
| extension-id: 'pdaldeopoccdhlkabbkcjmecmmoninhe' | ||
| file-path: ./packages/web-extension/dist/chrome.zip | ||
| client-id: ${{ secrets.CWS_CLIENT_ID }} | ||
| client-secret: ${{ secrets.CWS_CLIENT_SECRET }} | ||
| refresh-token: ${{ secrets.CWS_REFRESH_TOKEN }} | ||
| publish: true |
There was a problem hiding this comment.
As far as I can tell from here: https://github.com/changesets/action?tab=readme-ov-file#custom-publishing
You need to move the following code (including the new if statement) to .github/workflows/release.yml:
- uses: mnao305/[email protected]
if: steps.changesets.outputs.hasChangesets == 'false'
with:
extension-id: 'pdaldeopoccdhlkabbkcjmecmmoninhe'
file-path: ./packages/web-extension/dist/chrome.zip
client-id: ${{ secrets.CWS_CLIENT_ID }}
client-secret: ${{ secrets.CWS_CLIENT_SECRET }}
refresh-token: ${{ secrets.CWS_REFRESH_TOKEN }}
publish: true
| @@ -31,7 +31,7 @@ export default function Player() { | |||
|
|
|||
| const linkEl = document.createElement('link'); | |||
| linkEl.href = | |||
| 'https://cdn.jsdelivr.net/npm/rrweb-player@latest/dist/style.css'; | |||
| 'https://cdn.jsdelivr.net/npm/rrweb-player@alpha/dist/style.min.css'; | |||
There was a problem hiding this comment.
This is going to break once we go out of alpha, maybe you could pull in the version number directly from package.json we do in packages/web-extension/vite.config.ts
|
How would I even use this fix in my chrome extension that uses rrweb package? This fix only seems to fix chrome extension for this repo!! |
Changes: