fix: when inlineImages is true, image is cors, the image tag is broken

[xujiujiu]

inlineImages is true，image.src is cors, when start record，the image tag is broken

ccb.png is cors

not start

started

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3932cd9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[eoghanmurray]

It looks like we are the ones adding the crossorigin attribute on the image.
This is presumably a prerequisite to access the image as a blob.
As this can cause failure of image loading as you have discovered, we likely should do this in a separate new Image() instead. Or at least only add it if we have checked document.location.origin === (new URL(image.src)).origin

Also note that Justin is working on some async asset code loading in #1239 which will have the side effect of deprecate this inlineImages approach.

[xujiujiu]

It looks like we are the ones adding the crossorigin attribute on the image. This is presumably a prerequisite to access the image as a blob. As this can cause failure of image loading as you have discovered, we likely should do this in a separate new Image() instead. Or at least only add it if we have checked document.location.origin === (new URL(image.src)).origin

Also note that Justin is working on some async asset code loading in #1239 which will have the side effect of deprecate this inlineImages approach.

Will there be any configuration after #1239 that can instead of inlineImages? After all, we don’t want to affect the picture display speed due to the network speed during playback

[xujiujiu]

Tracking in PR of #1359